This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove unused timeout wallet CLI arg and config field #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2447 +/- ##
========================================
+ Coverage 76.9% 76.9% +<.1%
========================================
Files 110 110
Lines 17518 17510 -8
========================================
- Hits 13483 13481 -2
+ Misses 4035 4029 -6 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2447 +/- ##
========================================
+ Coverage 76.9% 76.9% +<.1%
========================================
Files 110 110
Lines 17518 17510 -8
========================================
- Hits 13483 13481 -2
+ Misses 4035 4029 -6 |
AshwinSekar
pushed a commit
to AshwinSekar/solana
that referenced
this pull request
Aug 6, 2024
The PoH speed check currently determines the target hash rate by reading values from genesis. However, the hashes per tick rate has been increased via feature gates. Thus, the speed check is using a slower hash rate for comparison than what is actually active. So, update the PoH speed check to derive PoH hash rate from a Bank instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of #2433 , the timeout wallet CLI arg and WalletConfig field are unused and unneeded. (Timeout was for
poll_gossip_for_leaderfunction.)Summary of Changes
Removes timeout stuffs from wallet.
Fixes #