This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix signature count #24471
Merged
Fix signature count #24471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
previously approved these changes
Apr 19, 2022
jstarry
approved these changes
Apr 19, 2022
t-nelson
approved these changes
Apr 19, 2022
|
Merging to kick off CI for v1.9 and v1.10 backports |
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Fix signature count * protect the signature count futher (cherry picked from commit 5d1adf1)
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Fix signature count * protect the signature count futher (cherry picked from commit 5d1adf1)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* Fix signature count * protect the signature count futher
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* Fix signature count * protect the signature count futher
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
* Fix signature count * protect the signature count futher
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
* Fix signature count * protect the signature count futher
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The bank's signature count is incremented even if a transaction is not executed due to invalid ComputeBudget instructions.
Summary of Changes
Only increment the signature count for the transactions that are executed.
Fixes #