This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix too many args in Tvu::new #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now pass in sockets through a the crate::tvu::Sockets struct Move ClusterInfo.keypair to pub(crate) in order to remove redundant signing keypair parameter
sakridge
reviewed
Dec 12, 2018
rob-solana
reviewed
Dec 12, 2018
rob-solana
approved these changes
Dec 12, 2018
|
thanks MarkJr94 for this contribution! |
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Jul 18, 2024
… startup (backport of solana-labs#1971) (solana-labs#2114) blockstore: only consume duplicate proofs from root_slot + 1 on startup (solana-labs#1971) * blockstore: only consume duplicate proofs from root_slot + 1 on startup * pr feedback: update test comments * pr feedback: add pub behind dcou for test fns (cherry picked from commit 2a48564) Co-authored-by: Ashwin Sekar <ashwin@anza.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tvu::newtakes too many arguments and is part of the public crate APISummary of Changes
Now pass in sockets through the
solana::tvu::SocketsstructMove
ClusterInfo::keypairtopub(crate)privacy in order to remove redundantsigning keypair parameter
Fixes #836