8000 First stab at Rust BPF by jackcmay · Pull Request #2269 · solana-labs/solana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

First stab at Rust BPF #2269

Merged
merged 3 commits into from
Jan 2, 2019
Merged

First stab at Rust BPF #2269

merged 3 commits into from
Jan 2, 2019

Conversation

jackcmay
Copy link
Contributor
@jackcmay jackcmay commented Dec 22, 2018 •
edited
Loading

Issue tracking the effort: #2268

@jackcmay jackcmay mentioned this pull request Dec 22, 2018
Closed
@codecov
Copy link
codecov bot commented Dec 23, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e3478ee). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #2269   +/-   ##
========================================
  Coverage          ?   73.6%           
========================================
  Files             ?     114           
  Lines             ?   17117           
  Branches          ?       0           
========================================
  Hits              ?   12609           
  Misses            ?    4508           
  Partials          ?       0

aeyakovenko
aeyakovenko approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member
@aeyakovenko aeyakovenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super rad! What are the limitations?

mvines
mvines reviewed Dec 23, 2018
View reviewed changes
garious
garious reviewed Dec 26, 2018
View reviewed changes
@jackcmay
Copy link
Contributor Author

@aeyakovenko
Limitations and general notes can be found in #2268. In general the limitations are that we can't use anything that doesn't get inlined and what does or does not get inlined is hard to quantify. Once support added for linking in libraries we can link in the libs we need (like Rusts Core lib). Check out #2268, I'm looking forward to comments and suggestions.

@jackcmay jackcmay added this to the v0.12 Beacons milestone Dec 27, 2018
@jackcmay jackcmay merged commit a461c56 into solana-labs:master Jan 2, 2019
@jackcmay jackcmay deleted the rust_bpf branch January 2, 2019 23:12
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2022
Open
KirillLykov pushed a commit to KirillLykov/solana that referenced this pull request Jul 25, 2024
@jstarry
refactor: replace measure_time with measure_us where appropriate (sol…
1519a2e 
…ana-labs#2269)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvines mvines mvines left review comments

@garious garious garious approved these changes

@aeyakovenko aeyakovenko aeyakovenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0 Beacons
Development

Successfully merging this pull request may close these issues.
4 participants
@jackcmay @garious @aeyakovenko @mvines
0