This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Update InvalidRentPayingAccount variant and message #23680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5867d1 to
6457633
Compare
Codecov Report
@@ Coverage Diff @@
## master #23680 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 580 580
Lines 158184 158252 +68
=========================================
- Hits 129341 129335 -6
- Misses 28843 28917 +74 |
jstarry
approved these changes
Mar 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit 410463f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
InvalidRentPayingAccount error message is confusing because it still refers to accounts "with data", even though the implementation in #22292 prevents all rent-paying accounts.
Summary of Changes
Update InvalidRentPayingAccount error message
Also include relevant account index to make it more helpful(edit) actually, I removed this bit. Plumbing the account index into storage-protobuf types was a little annoying, and will make activation ofrequire_rent_exempt_accountsdependent on this PR. Would rather not be adding another consensus-breaking changeFixes #23670