Output BankHashDetails file when leader drops its' own block #34256
Conversation
Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34256 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219387 219406 +19
=======================================
+ Hits 179690 179745 +55
+ Misses 39697 39661 -36 |
Agreed, that is currently a work in progress 😉 for v1.16. I'm going to add the v1.17 label to this PR for now; will make sure to get buy in from Will and/or Trent for that one before submitting |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block. Output the file in this additional failure codepath (cherry picked from commit 935e06f)
…backport of #34256) (#34275) Output BankHashDetails file when leader drops its' own block (#34256) Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block. Output the file in this additional failure codepath (cherry picked from commit 935e06f) Co-authored-by: steviez <steven@solana.com>
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. 8000 Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block. Output the file in this additional failure codepath (cherry picked from commit 935e06f)
…backport of #34256) (#34302) Output BankHashDetails file when leader drops its' own block (#34256) Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block. Output the file in this additional failure codepath (cherry picked from commit 935e06f) Co-authored-by: steviez <steven@solana.com>
Problem
Summary of Changes
Note that the debug file gets generated when we are not the leader via
ReplayStage::purge_unconfirmed_duplicate_slot():solana/core/src/replay_stage.rs
Line 1510 in e425c1a