This repository was archived by the owner on Jan 22, 2025. It is now read-only.
update pubsub docs link #34380
Merged
update pubsub docs link #34380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34380 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 819 819
Lines 220991 220991
=========================================
- Hits 180931 180925 -6
- Misses 40060 40066 +6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The docs in the
PubsubClientdont have the the latest link to the socket events. So the links to the events they refer to are updated.For eg:
The latest link referring to
account_subscribeevents ishttps://docs.solana.com/api/websocket#accountsubscribe
But the link in the docs still refer to the old one.
https://docs.solana.com/developing/clients/jsonrpc-api#accountsubscribe
This PR tries to update those links.
Summary of Changes