8000 V1.17.11 version bump by steviez · Pull Request #34451 · solana-labs/solana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

V1.17.11 version bump #34451

Merged
merged 2 commits into from
Dec 14, 2023
Merged

V1.17.11 version bump #34451

merged 2 commits into from
Dec 14, 2023

Conversation

steviez
Copy link
Contributor
@steviez steviez commented Dec 13, 2023 •
edited
Loading

Summary of Changes

  • Run ./scripts/increment-cargo-version.sh patch
  • Manually undo the hashbrown update

@steviez
Copy link
Contributor Author
steviez commented Dec 13, 2023 •
edited
Loading

Per some discussion with Tyera, we realized that this action should be getting done automatically. However, the job failed:
https://github.com/solana-labs/solana/actions/runs/7200995161/job/19616164931

Will look at resolving that, Tyera and I both suspect that a script broke and was never updated when we moved to workspace inheritance

Edit: hit the wrong button, and accidentally closed the PR instead of commenting

@steviez steviez closed this Dec 13, 2023
@steviez steviez reopened this Dec 13, 2023
@steviez steviez mentioned this pull request Dec 13, 2023
Merged
@steviez steviez marked this pull request as ready for review December 13, 2023 23:55
@CriesofCarrots
Copy link
Contributor

Haha, @willhickey sniped you during that close-reopen: #34452

@steviez
Copy link
Contributor Author
steviez commented Dec 13, 2023 •
edited
Loading

Haha, @willhickey sniped you during that close-reopen: #34452

lolol, I think his CI has like a 15-20 second lead on me; at least the line counts match up between our PR's

@willhickey willhickey mentioned this pull request Dec 13, 2023
Closed
@willhickey
Copy link
Contributor

Oh bother I missed this.

Yeah, the automated solution fails for 2 reasons I'm aware of:

  1. It no longer has permission to create a branch in the monorepo. I could let it create a branch in my fork instead. In theory it's possible to grant the action runner permission to create a branch but the last time I tried I couldn't make it work (forum posts allude to it being possible though)
  2. the hashbrown dependency updating

I'll get the automation working again at some point

@codecov Codecov
Copy link
codecov bot commented Dec 14, 2023

Codecov Report

Merging #34451 (ca80a12) into v1.17 (928e384) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##            v1.17   #34451   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         803      803           
  Lines      218166   218166           
=======================================
+ Hits       178515   178516    +1     
+ Misses      39651    39650    -1

@willhickey willhickey merged commit 28e8af4 into solana-labs:v1.17 Dec 14, 2023
@steviez steviez deleted the v1.17.11_version_bump branch December 14, 2023 01:37
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willhickey willhickey willhickey approved these changes

@CriesofCarrots CriesofCarrots Awaiting requested review from CriesofCarrots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steviez @CriesofCarrots @willhickey
0