8000 validator: skip health check by diman-io · Pull Request #33568 · solana-labs/solana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

validator: skip health check #33568

Merged
merged 2 commits into from
Oct 8, 2023
Merged

validator: skip health check #33568

merged 2 commits into from
Oct 8, 2023

Conversation

diman-io
Copy link
Contributor
@diman-io diman-io commented Oct 6, 2023

Problem

Issues with getHealth are known: #16957 And I believe that the issue will be fundamentally resolved.
But right now, I'm concerned about updating the validator using wait-for-restart-window and exit.
There are already a lot of messages in the chats for 1.16.
I propose this tiny change that would allow bypassing the health check.

I sincerely hope for v1.16 and v1.17

Summary of Changes

Added the --skip-health-check flag for the wait-for-restart-window and exit commands

Fixes #33553

@codecov
Copy link
codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #33568 (36045c5) into master (c588f25) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           master   #33568     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         807      807             
  Lines      218283   218287      +4     
=========================================
- Hits       178485   178467     -18     
- Misses      39798    39820     +22

mvines
mvines reviewed Oct 6, 2023
View reviewed changes
@diman-io diman-io force-pushed the diman/pr/skip-health-check branch from b7faa48 to 36045c5 Compare October 8, 2023 16:07
@diman-io diman-io requested a review from mvines October 8, 2023 21:27
mvines
mvines approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor
@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@mvines mvines merged commit 7afb11f into solana-labs:master Oct 8, 2023
@diman-io
Copy link
Contributor Author
diman-io commented Oct 9, 2023 •
edited
Loading

Hi @mvines, no chance for v1.16 v1.17 ?

@mvines mvines added the v1.17 PRs that should be backported to v1.17 label Oct 9, 2023
@mvines
Copy link
Contributor
mvines commented Oct 9, 2023

v1.17 seems fine to me, it's not really a critical bug fix so i don't feel like a v1.16 backport is appropriate, even though I appreciate this is a low risk change

mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@diman-io @mergify
validator: skip health check (#33568)
4be12ed 
* validator: skip health check

* keep `healthy` as a boolean

(cherry picked from commit 7afb11f)
@mergify mergify bot mentioned this pull request Oct 9, 2023
Merged
mvines pushed a commit that referenced this pull request Oct 13, 2023
@mergify @diman-io
v1.17: validator: skip health check (backport of #33568) (#33588)
8d27072 
validator: skip health check (#33568)

* validator: skip health check

* keep `healthy` as a boolean

(cherry picked from commit 7afb11f)

Co-authored-by: DimAn <diman@diman.io>
@steviez steviez mentioned this pull request Oct 16, 2023
Merged
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvines mvines mvines approved these changes

Assignees
No one assigned
Labels
need:merge-assist v1.17 PRs that should be backported to v1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validator: default health check slot distance
2 participants
@diman-io @mvines
0