8000 Add queuestat changes for aggregate VOQ counters by vivekverma-arista · Pull Request #3617 · sonic-net/sonic-utilities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add queuestat changes for aggregate VOQ counters #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add queuestat changes for aggregate VOQ counters #3617

wants to merge 18 commits into from

Conversation

vivekverma-arista
Copy link
@vivekverma-arista vivekverma-arista commented Nov 14, 2024 •
edited
Loading

This feature has been tracked in #1543
HLD PR: 1957

What I did

Add queuestat changes for aggregate VOQ counters.

How I did it

Existing CLI show queue counters --voq is being implemented for supervisor. This will access all the ASIC database instances on every linecard which are now exposed to midplane network by this PR20803 and sum up counters for each VOQ.

Also depends on #560, #1003 and #147

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

This was referenced Nov 14, 2024
Merged
Closed
@kenneth-arista
Copy link
Contributor

@arlakshm for awareness

@kenneth-arista
Copy link
Contributor

Tracking issue: sonic-net/SONiC#1543

@rlhui rlhui requested a review from vmittal-msft November 27, 2024 22:38
@vmittal-msft
Copy link
Contributor

@vivekverma-arista

  1. Please share output from supervisor as well as line card using one port/voq as an example.
  2. Do we have separate PR for clear counter ?
  3. Did we check if queuestat still works for non chassis ?

@vmittal-msft vmittal-msft requested a review from arlakshm December 5, 2024 18:46
@vmittal-msft
Copy link
Contributor

Otherwise changes looks ok to me.

@vivekverma-arista
Copy link
Author

@vivekverma-arista

  1. Please share output from supervisor as well as line card using one port/voq as an example.
  2. Do we have separate PR for clear counter ?
  3. Did we check if queuestat still works for non chassis ?

Hi @vmittal-msft, I will answer/address these points. Meanwhile could you also take a look at another related PR sonic-net/sonic-buildimage#20803 and confirm that the approach is okay so that we can start making progress with unit tests.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft
Copy link
Contributor

Approved the dependent PR, please help answer few questions i pasted above.

@vivekverma-arista
Copy link
Author
vivekverma-arista commented Jan 26, 2025 •
edited
Loading

PR20803

@vmittal-msft

  1. Manual testing with traffic for System Port cmp217-5|asic1|Ethernet256

From Linecard

admin@cmp217-5:~$ show queue counters -n asic0 "cmp217-5|asic1|Ethernet256" --voq
For namespace asic0:
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0             123             6150            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              12              600            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2            1000            50000            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3             456            22800            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4             211            10550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              24             1200            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7               0                0            0             0                     0

admin@cmp217-5:~$ show queue counters -n asic1 "cmp217-5|asic1|Ethernet256" --voq
For namespace asic1:
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0            1111            55550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2               9              450            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3              91             4550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4              55             2750            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5              88             4400            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              21             1050            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7              48            14437            0             0                     0

From supervisor

admin@cmp217:~$ show queue counters "cmp217-5|asic1|Ethernet256" --voq
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0            1234            61700            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              57             2850            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2            1009            50450            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3             547            27350            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4             266            13300            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5             133             6650            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7              52            15809            0             0                     0

  1. Clear functionality is not currently supported for aggregated VOQ counters on supervisor and would need some more work.

  2. Queuestat still works fine on T0/T1 devices.

@vmittal-msft
Copy link
Contributor

@vivekverma-arista Changes looks good to me. Please add clear counter support to it as well for SUP as well as LC (if not there).

@vmittal-msft
Copy link
Contributor

@vivekverma-arista Please share if you are going to handle clear counter as part of this PR or different PR.

vmittal-msft
vmittal-msft previously approved these changes Feb 20, 2025
View reviewed changes
@vivekverma-arista
Copy link
Author

@vivekverma-arista Please share if you are going to handle clear counter as part of this PR or different PR.

I will raise a separate PR for clear support as it needs additional work.

@vivekverma-arista vivekverma-arista mentioned this pull request Apr 8, 2025
Open
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

@vivekverma-arista, can check on the pretest and test failures?

vmittal-msft
vmittal-msft previously approved these changes Jun 18, 2025
View reviewed changes
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@rlhui
Copy link
Contributor
rlhui commented Jun 25, 2025

@vivekverma-arista , would you please check failures? thanks

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmittal-msft vmittal-msft vmittal-msft left review comments

@arlakshm arlakshm Awaiting requested review from arlakshm

@saksarav-nokia saksarav-nokia Awaiting requested review from saksarav-nokia

@kenneth-arista kenneth-arista Awaiting requested review from kenneth-arista

At least 1 approving review is required to merge this pull request.

Assignees

@vivekverma-arista vivekverma-arista

Labels
None yet
Projects
SONiC Chassis
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vivekverma-arista @kenneth-arista @vmittal-msft @mssonicbld @abdosi @arlakshm @rlhui
0