8000 [sonic-package-manager] Save tag that was used to install the application by DavidZagury · Pull Request #3917 · sonic-net/sonic-utilities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[sonic-package-manager] Save tag that was used to install the application #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[sonic-package-manager] Save tag that was used to install the application #3917

wants to merge 7 commits into from

Conversation

DavidZagury
Copy link
Contributor
@DavidZagury DavidZagury commented Jun 10, 2025 •
edited
Loading

What I did

  • Added functionality to save and track the Docker image tag used during package installation
  • Modified the service creator to include the tag information in container configuration
  • This change will improve visibility in docker ps output by showing the actual tag used for each container

How I did it

  • Added a new tag field to the Package class to store the image tag
  • Modified the PackageSource class to save the tag from the installed image
  • Updated the ServiceCreator to include the tag information in the container configuration
  • The tag is extracted from the first tag in the image's tags list during installation

How to verify it

  1. Install a package using sonic-package-manager
  2. Run docker ps to verify that the container is running with the correct tag
  3. Check the container configuration to ensure the tag is properly saved

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@DavidZagury
[sonic-package-manager] Save tag that was used to install the applica…
553951e 
…tion

This is done in order to be able to start using tag which will provide a user-friendly identifier when running docker ps.
@DavidZagury
Use id when no tag is available
d6bc279
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2025
Open
Open
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_fix_app_extension_instllation branch from bb60cdf to d3a2d96 Compare June 11, 2025 11:10
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_fix_app_extension_instllation branch from 15dda49 to 2ce12a7 Compare June 11, 2025 14:24
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_fix_app_extension_instllation branch from 2ce12a7 to 044d5a6 Compare June 11, 2025 14:26
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_fix_app_extension_instllation branch from 044d5a6 to de52c45 Compare June 11, 2025 15:53
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_fix_app_extension_instllation branch from de52c45 to e473669 Compare June 11, 2025 16:27
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@liushilongbuaa liushilongbuaa Awaiting requested review from liushilongbuaa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Request for 202505 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidZagury @mssonicbld @stepanblyschak
0