Fix for 22138: Chassisd does not wait for the execution to complete for previous admin state change requests - Replaces PR: #3845 #3937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for previous admin state change requests - replaces sonic-net#3845
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds state transition tracking for chassis module admin state changes, ensuring no overlapping operations and timing out stale transitions.
- Introduces
StateDBHelperand helper functions for tracking transition state in STATE_DB - Extends
shutdown_chassis_moduleandstartup_chassis_moduleto guard against concurrent transitions and handle timeouts - Adds comprehensive tests for transition tracking and timeout logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| config/chassis_modules.py | Added state-tracking helpers, ensure_statedb_connected, and updated startup/shutdown commands to include transition checks and timeouts |
| tests/chassis_modules_test.py | New tests covering transition tracking, timeout behavior, and helper functions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gpunathilell
approved these changes
Jun 26, 2025
vvolam
approved these changes
Jun 26, 2025
|
@rameshraghupathy could you please comment "/azpw run" to re-run the pipeline?? |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to 202505: #3940 |
rlhui
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2025
…in state change requests. Fixed issue #22138 (#607) Fixed issue #22138 Chassisd does not wait for the execution to complete for previous admin state change requests. Added support to solve this. The corresponding sonic-utilities PR is: sonic-net/sonic-utilities#3937 Motivation and Context Added a state to indicate the progress of an admin_state transition period (window) of every module in config_db. When in progress do not allow another admin_state change for that module. Mark the beginning of state transition in the CLI itself. Added a timeout also for error cases. Mark the end of state transition in chassisd
mssonicbld
added a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Jul 1, 2025
…in state change requests. Fixed issue #22138 Chassisd does not wait for the execution to complete for previous admin state change requests. Fixed issue #22138 #### Description Fixed issue #22138 Chassisd does not wait for the execution to complete for previous admin state change requests. Added support to solve this. The corresponding sonic-utilities PR is: sonic-net/sonic-utilities#3937 #### Motivation and Context Added a state to indicate the progress of an admin_state transition period (window) of every module in config_db. When in progress do not allow another admin_state change for that module. Mark the beginning of state transition in the CLI itself. Added a timeout also for error cases. Mark the end of state transition in chassisd #### How Has This Been Tested? ssue "config chassis module startup DPU0". This takes around 3 mins. Check the config_db and verify the new variable is set to True. Issue another "config chassis module startup DPU0" and also ""config chassis module shutdown DPU0". See both are blocked. Once the DPU operational state is the admin_sate check if a new config is accepted. #### Request for 202505 - [x] 202505 #### Additional Information (Optional) Goes with PR: sonic-net/sonic-utilities#3845
mssonicbld
added a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Jul 1, 2025
…in state change requests. Fixed issue #22138 (#637) Chassisd does not wait for the execution to complete for previous admin state change requests. Fixed issue #22138 #### Description Fixed issue #22138 Chassisd does not wait for the execution to complete for previous admin state change requests. Added support to solve this. The corresponding sonic-utilities PR is: sonic-net/sonic-utilities#3937 #### Motivation and Context Added a state to indicate the progress of an admin_state transition period (window) of every module in config_db. When in progress do not allow another admin_state change for that module. Mark the beginning of state transition in the CLI itself. Added a timeout also for error cases. Mark the end of state transition in chassisd #### How Has This Been Tested? ssue "config chassis module startup DPU0". This takes around 3 mins. Check the config_db and verify the new variable is set to True. Issue another "config chassis module startup DPU0" and also ""config chassis module shutdown DPU0". See both are blocked. Once the DPU operational state is the admin_sate check if a new config is accepted. #### Request for 202505 - [x] 202505 #### Additional Information (Optional) Goes with PR: sonic-net/sonic-utilities#3845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #22138
Replaces PR: #3845 which was closed accidentally
The corresponding sonic-platform-daemon PR is : sonic-net/sonic-platform-daemons#607
What I did
Fixed issue #22138
Chassisd does not wait for the execution to complete for previous admin state change requests. Added support to solve this.
How I did it
Added a state to indicate the progress of an admin_state transition period (window) of every module in config_db.
When in progress do not allow another admin_state change for that module.
Mark the beginning of state transition in the CLI itself. Added a timeout also for error cases.
Mark the end of state transition in chassisd.
How to verify it
Issue "config chassis module startup DPU0". This takes around 3 mins. Check the config_db and verify the new variable is set to True.
Issue another "config chassis module startup DPU0" and also ""config chassis module shutdown DPU0".
See both are blocked.
Once the DPU operational state is the admin_sate check if a new config is accepted.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Request for 202505