8000 [config show]BGP Suppress fib pending config and display for multi-asic by vganesan-nokia · Pull Request #3948 · sonic-net/sonic-utilities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[config show]BGP Suppress fib pending config and display for multi-asic #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vganesan-nokia
Copy link
Contributor

What I did

CLI commands part of the fix for issue (sonic-net/sonic-buildimage#19022)

How I did it

  • Config to take namespace option to send the suppress-fib-pending configuration to asic specific config db.
  • Show command to take optional namespace to diplay current suppress-fib-pending configuration.
  • Unit tests to test the multi-asic support of suppress-fib-pending configuration

How to verify it

  • In a multi-asic device configure suppress-fib-pending using command "sudo config suppress-fib-pending -n asic0 enabled"
  • Check the config db of respective config db whether the "suppress_fib_pending": "enabled" fv pair is avialable in the config db DEVICE_METADATA
  • Run the same test for different asic and "disabled"

Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show suppress-fib-pending 
Enabled

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show suppress-fib-pending 
asic0: Enabled
asic1: Enabled
admin@sonic:~$ 

admin@sonic:~$ show suppress-fib-pending -n asic0
asic0: Enabled
admin@sonic:~$ 

CLI commands changes to fix issue (sonic-net/sonic-buildimage#19022)
- Config to take namespace option to send the suppress-fib-pending configuration to asic
  specific config db.
- Show command to take optional namespace to diplay current suppress-fib-pending configuration.
- Unit tests to test the multi-asic support of suppress-fib-pending configuration

Signed-off-by: vedganes <veda.ganesan@nokia.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Fixed added for issues found in pre-commit checks

Signed-off-by: vedganes <veda.ganesan@nokia.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Changes done to revert config db fv field name "suppress_fib_pending" to
previous "suppress-fib-pending"

Signed-off-by: vedganes <veda.ganesan@nokia.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0