8000 Always add P in String() method by astappiev · Pull Request #1 · sosodev/duration · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Always add P in String() method #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2023
Merged

Always add P in String() method #1

merged 5 commits into from
Apr 6, 2023

Conversation

astappiev
Copy link
Contributor

As of now, when I create a duration like

duration.Duration{Minutes: 10}

and then calling String() returns T10M when PT10M is expected.

@sosodev
Copy link
Owner
sosodev commented Feb 23, 2023

Ah good catch. I had misread that part of the spec. Could you fix the failing test cases?

@astappiev
Copy link
Contributor Author
astappiev commented Apr 3, 2023 •
edited
Loading

Any chance to be merged soon?

sosodev
sosodev requested changes Apr 5, 2023
View reviewed changes
Copy link
Owner
@sosodev sosodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, apologies for the slow review. Would you like to make these changes? If not I'm happy to merge and make them myself.

sosodev
sosodev reviewed Apr 5, 2023
View reviewed changes
sosodev
sosodev reviewed Apr 5, 2023
View reviewed changes
@sosodev
Copy link
Owner
sosodev commented Apr 5, 2023

This is looking really good. Left a couple more comments.

@astappiev astappiev requested a review from sosodev April 5, 2023 21:07
@sosodev sosodev merged commit 3054e00 into sosodev:main Apr 6, 2023
@sosodev
Copy link
Owner
sosodev commented Apr 6, 2023

@astappiev Merged! Thanks for putting this together. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosodev sosodev Awaiting requested review from sosodev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astappiev @sosodev
0