8000 Add Json marshaling and unmarshaling by arieroos · Pull Request #3 · sosodev/duration · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Json marshaling and unmarshaling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add Json marshaling and unmarshaling #3

merged 2 commits into from
Oct 12, 2023

Conversation

arieroos
Copy link
Contributor

This should close #2

I thought it's a good idea. And some contributions to this package will help it's longevity

sosodev
sosodev requested changes Oct 11, 2023
View reviewed changes
Copy link
Owner
@sosodev sosodev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. Sorry for the slow review. Overall this looks good but the tests are failing.

@arieroos
Copy link
Contributor Author

Thanks a million for the review. No need to apologise for taking your time.

I pushed a commit with your suggested fix

@arieroos arieroos requested a review from sosodev October 11, 2023 07:20
@sosodev sosodev merged commit 21da944 into sosodev:main Oct 12, 2023
@sosodev
Copy link
Owner
sosodev commented Oct 12, 2023

@arieroos merged. Thanks again for your contribution. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosodev sosodev sosodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for JSON marshaling/unmarshaling
2 participants
@arieroos @sosodev
0