10000 `srb rbi` should not be an alias for `srb init` · Issue #1006 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

srb rbi should not be an alias for srb init #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olbrich opened this issue Jun 22, 2019 · 2 comments
Closed

srb rbi should not be an alias for srb init #1006

olbrich opened this issue Jun 22, 2019 · 2 comments
Labels
enhancement New feature or surprising current feature good first issue Good for newcomers

Comments

@olbrich
Copy link
olbrich commented Jun 22, 2019 •
edited by jez
Loading

Input

$ srb rbi

Observed output

👋 Hey there!

This script will get this project ready to use with Sorbet by creating a
sorbet/ folder for your project. It will contain:

- a config file
- a bunch of 'RBI files'

RBI stands for 'Ruby Interface'; these files define classes, methods, and
constants that exist, but which Sorbet doesn't always know about.

⚠️  Heads up:

To set up your project, this script will take two potentially destructive
actions:

1.  It will require every file in your project. Specifically, every script in
    your project will be run, unless that script checks if __FILE__ == $PROGRAM_NAME
    before running any code, or has the magic comment # typed: ignore in it.

2.  It will add a comment to the top of every file (like # typed: false or
    # typed: true, depending on how many errors were found in that file.)

❔ Would you like to continue? [Y/n]

Expected behavior

This is the same output returned for srb init.

We should make srb rbi with no further subcommand exit with an error and display the available subcommands. To explicitly update all RBI files, the user should write srb rbi update.
@olbrich olbrich added bug Something isn't working unconfirmed This issue has not yet been confirmed by the Sorbet team labels Jun 22, 2019
@jez jez added enhancement New feature or surprising current feature good first issue Good for newcomers and removed bug Something isn't working unconfirmed This issue has not yet been confirmed by the Sorbet team labels Jun 23, 2019
@jez jez changed the title srb rbi appears to do the same thing as srb init srb rbi should not be an alias for srb init Jun 23, 2019
pje added a commit to pje/sorbet that referenced this issue Jun 26, 2019
@pje
srb-rbi with no args just prints usage (sorbet#1006)
525afb7
@pje pje mentioned this issue Jun 26, 2019
Merged
jez pushed a commit that referenced this issue Jul 3, 2019
@pje @jez
srb-rbi with no args just prints usage (#1006) (#1063)
a1a4384 
* Rebase from master, decrease diff size as much as possible

* Fix tests
@jasnow
Copy link
Contributor
jasnow commented Jul 12, 2019

@olbrich - This issue appears to have be fixed.

pje added a commit to pje/sorbet that referenced this issue Jul 15, 2019
@pje
srb-rbi with no args just prints usage (sorbet#1006) (sorbet#1063)
791fcef 
* Rebase from master, decrease diff size as much as possible

* Fix tests
@aisamanra
Copy link
Contributor

This was fixed by #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or surprising current feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@olbrich @jasnow @aisamanra @jez
0