Update savePackageFiles to only work on modified files
#7240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to `savePackageFiles` so - only modified `__package.rb` files are saved. - logic leaves early if there is nothing to save. - it is compatible OS agnostic (use of `/` is platform specific).
jez
approved these changes
Aug 18, 2023
froydnj
approved these changes
Aug 18, 2023
ilyailya
pushed a commit
that referenced
this pull request
Sep 6, 2023
Update to `savePackageFiles` so - only modified `__package.rb` files are saved. - logic leaves early if there is nothing to save. - it is compatible OS agnostic (use of `/` is platform specific).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
savePackageFilesso__package.rbfiles are looked at./is platform specific).Motivation
Follow-up to #7214
Test plan
See included automated tests.