Allow passing *.exp paths to update_testdata_exp.sh
#8790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes I want to be able to regenerate all the `*.exp` files for a
certain kind of expectation. There are two ways to do this:
1. regenerate everything
2. list out each `*.rb` file that has that kind of exp
Doing the second approach always requires writing some fiddly shell
code, and it's easier to just have it here. Now you can do something
like this:
tools/scripts/update_testdata_exp.sh test/testdata/**/*.package.exp
which saves time.
froydnj
requested changes
Apr 24, 2025
tools/scripts/update_testdata_exp.sh
Outdated
| fi | ||
| fi | ||
|
|
||
| paths=("$path") |
There was a problem hiding this comment.
This doesn't accumulate the paths properly.
froydnj
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes I want to be able to regenerate all the
*.expfiles for acertain kind of expectation. There are two ways to do this:
*.rbfile that has that kind of expDoing the second approach always requires writing some fiddly shell
code, and it's easier to just have it here. Now you can do something
like this:
which saves time.
Test plan
Tested manually on another branch where I'm changing exp files.