8000 Accept `env` argument for `Open3.popen3` by vinistock · Pull Request #8804 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accept env argument for Open3.popen3 #8804

New issue
Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Accept env argument for Open3.popen3 #8804

merged 1 commit into from
Apr 29, 2025

Conversation

vinistock
Copy link
Collaborator

Changed the RBI to accept an env argument, which also works as the first command for the splat chain.

Motivation

The popen3 method and family all accept that the first argument of the splat be additional environment variables (docs).

Test plan

I added a test case for the testdata/rbi directory.

@vinistock vinistock requested a review from a team as a code owner April 28, 2025 18:20
@vinistock vinistock requested review from jez and removed request for a team April 28, 2025 18:20
@vinistock vinistock mentioned this pull request Apr 28, 2025
Merged
@jez
Copy link
Collaborator
jez commented Apr 29, 2025

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_SDj4XO4RsLYsGA
→ https://go/builds/bui_SDj4Otx2wiAPiD
→ https://go/builds/bui_SDj5mLcBnJOW5r

@jez jez merged commit 25b7c8f into sorbet:master Apr 29, 2025
15 checks passed
@vinistock vinistock deleted the vs-accept-env-for-popen3 branch April 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @jez
0