Add more cancellation points to resolveConstants #8809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
commented
Apr 30, 2025
| computedTreesCount++; | ||
|
|
||
| if (!cancelled) { | ||
| if (computedTreesCount % 250 == 0 && gs.epochManager->wasTypecheckingCanceled()) { |
There was a problem hiding this comment.
This number is arbitrary, and taken from namer.cc.
jez
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolveConstantsstep of the resolver is currently one of the long poles between cancellation points, and this PR addresses that by adding cancellation to the most expensive part: the initial traversal of the input trees.Motivation
Improving cancellation latency in LSP.
Test plan
Existing tests.