8000 Add RBI signatures for `ENV#merge!` by Morriar · Pull Request #8803 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add RBI signatures for ENV#merge! #8803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

Morriar
Copy link
Collaborator
@Morriar Morriar commented Apr 28, 2025

Motivation

See https://docs.ruby-lang.org/en/master/ENV.html#method-c-merge-21.

Test plan

See included automated tests.

@Morriar Morriar requested a review from a team as a code owner April 28, 2025 17:23
@Morriar Morriar requested review from elliottt and removed request for a team April 28, 2025 17:23
@Morriar Morriar self-assigned this Apr 28, 2025
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just want to check on the ENVClass arguments before merging.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@elliottt elliottt merged commit c87a440 into sorbet:master Apr 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0