8000 rbi: Add RactorLocalSingleton by jez · Pull Request #8825 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rbi: Add RactorLocalSingleton #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

rbi: Add RactorLocalSingleton #8825

merged 1 commit into from
May 5, 2025

Conversation

jez
Copy link
Collaborator
@jez jez commented May 5, 2025

Motivation

Fixes #8822

It looks like the singleton gem added a new module which is a subclass
of SingletonClassMethods:

It's not documented and the feature seems to have been accepted in the
face of pushback but we may as well have RBI definitions for it so that
it doesn't generate a hidden-definitions error.

Test plan

Have not tested

Fixes #8822

It looks like the `singleton` gem added a new module which is a subclass
of `SingletonClassMethods`:

- https://bugs.ruby-lang.org/issues/18127
- ruby/singleton#4

It's not documented and the feature seems to have been accepted in the
face of pushback but we may as well have RBI definitions for it so 
AB7E
that
it doesn't generate a hidden-definitions error.
@jez jez requested a review from a team as a code owner May 5, 2025 16:16
@jez jez requested review from elliottt and removed request for a team May 5, 2025 16:16
@jez jez merged commit d50a1c6 into master May 5, 2025
14 checks passed
@jez jez deleted the jez-ractor-local-singleton branch May 5, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has_attached_class! error with Ruby internal Singleton
2 participants
0