Update LSP state diagrams #8844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jez
approved these changes
May 7, 2025
| @@ -80,7 +84,7 @@ sequenceDiagram | |||
| Note right of LSPIndexer: Copy GlobalState for<br/>the slow path | |||
| LSPLoop --) LSPTypechecker: SorbetWorkspaceEditTask::runSpecial | |||
| LSPTypechecker ->> LSPTypechecker: LSPTypechecker::runSlowPath | |||
| Note right of LSPTypechecker: Save old GlobalState<br/>and run the pipeline | |||
| Note right of LSPTypechecker: pipeline::copyForSlowPath<br/>and run the pipeline | |||
There was a problem hiding this comment.
We have one note "pipeline::copyForSlowPath" and another node "Copy GlobalState for the slow path"
not sure whether that's intentional (fine if it is) but if they're actually using the same logic and we wanted to make that clear in the note, now would be a time to do that.
There was a problem hiding this comment.
Good catch, the Copy GlobalState... one is no longer relevant.
| can be sent back to the indexer thread. This copy is made early on, as the | ||
| indexer thread will never run passes that depend on the symbol tables being | ||
| populated, and thus it would be a waste of memory to copy the `GlobalState` at | ||
| the end of the whole pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the LSP docs to reflect the recent changes that add reindexing to the slow path.
Motivation
Keeping the internal docs up to date.
Test plan
Doc only change.