8000 Delete a bunch of `std::` by jez · Pull Request #8849 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Delete a bunch of std:: #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 16, 2025
Merged

Delete a bunch of std:: #8849

merged 19 commits into from
May 16, 2025

Conversation

jez
Copy link
Collaborator
@jez jez commented May 8, 2025

Motivation

Consistency, vanity.

Test plan

Existing tests

@jez jez requested a review from a team as a code owner May 8, 2025 04:26
@jez jez requested review from froydnj and removed request for a team May 8, 2025 04:26
froydnj
froydnj approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanity, vanity, everything is vanity.

Morriar
Morriar approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator
@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there some kind of linter we could enable for this?

@jez jez enabled auto-merge (squash) May 14, 2025 00:15
@jez jez force-pushed the jez-std branch 2 times, most recently from 77aa040 to f1ed40d Compare May 16, 2025 00:10
@jez jez merged commit add746f into master May 16, 2025
14 checks passed
@jez jez deleted the jez-std branch May 16, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

@Morriar Morriar Morriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jez @froydnj @Morriar
0