Split defining packages apart from imports/exports #8840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
approved these changes
May 7, 2025
| setPackageNameOnFiles(gs, files); | ||
|
|
||
| { | ||
| auto packages = gs.unfreezePackages(); |
There was a problem hiding this comment.
I think you need to unfreeze the name table here as well, as populatePackageEdges will potentially introduce new names.
There was a problem hiding this comment.
yeah I got this confused when I extracted it from another branch I'm working on where I stop creating MangledNames for packages that don't exist, meaning that resolving import and visible_to lines doesn't require entering new names
I'll add it back to this and make a note to delete it eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is more similar to the way that namer is split, with three phases:
If we're going to use namer to enter packages, we need to model that a bit more closely. In particular, we won't be able to resolve the
importsof a package until thesymbolizeTreesphase, which means we need to split defining packages and populating the imports.This is all the no-op prework to get us closer, but there are more changes coming.
Test plan
Existing tests.