8000 Drop threads back to 16MB stack by elliottt · Pull Request #8853 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Drop threads back to 16MB stack #8853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Drop threads back to 16MB stack #8853

merged 1 commit into from
May 9, 2025

Conversation

elliottt
Copy link
Collaborator
@elliottt elliottt commented May 9, 2025 •
edited
Loading

Also remove the darwindbg config_setting, and the associated build configuration that depended on it and would set the main thread's stack size.

I think this could probably be smaller than 16MB: running on Stripe's codebase indicated that we're well within that limit.

Motivation

Tightening up resource limits a bit in anticipation of adding a second worker pool.

Test plan

Existing tests.

@elliottt
Drop threads back to 16MB stack
c8c12c9 
Also remove the darwindbg config_setting, and the associated build
configuration that depended on it and would set the main thread's stack
size.
8000
@elliottt elliottt marked this pull request as ready for review May 9, 2025 01:50
@elliottt elliottt requested a review from a team as a code owner May 9, 2025 01:50
@elliottt elliottt requested review from froydnj and removed request for a team May 9, 2025 01:50
@froydnj
Copy link
Contributor
froydnj commented May 9, 2025

Did you test this on an actual Darwin debug build with a test suite run, at least?

@elliottt
Copy link
Collaborator Author
elliottt commented May 9, 2025

Did you test this on an actual Darwin debug build with a test suite run, at least?

I'm not convinced that the setting as it is now is doing anything, but I'll run a local test.

The following output was run on master:

% bazel build //main:sorbet --config=dbg -c dbg
INFO: Analyzed target //main:sorbet (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //main:sorbet up-to-date:
  bazel-bin/main/sorbet
INFO: Elapsed time: 0.209s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
trevor ~/stripe/sorbet (master &)
% otool -lV ./bazel-bin/main/sorbet | rg stacksize
 stacksize 0

@elliottt elliottt merged commit 035cf42 into master May 9, 2025
14 checks passed
@elliottt elliottt deleted the trevor/reduce-stack-sizes branch May 9, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliottt @froydnj @jez
0