8000 Clarify a comment in LSPTypecheckerCoordinator by jez · Pull Request #8861 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify a comment in LSPTypecheckerCoordinator #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Clarify a comment in LSPTypecheckerCoordinator #8861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions main/lsp/LSPTypecheckerCoordinator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ class LSPTypecheckerCoordinator final {
// the global state for the first time.
std::shared_ptr<TaskQueue> taskQueue;

// The worker pool used specifically for preemption tasks. This pool has the same number of threads as `workers`,
// because running preemption tasks implies that `workers` pool is suspended waiting for the preemption task to
// finish.
// The worker pool used specifically for preemption tasks. This pool has the same number of
// threads as `workers` so that running preemption tasks can use as many threads as a slowpath
// task would.
//
// (When running preemption tasks, every thread in the main `workers` pool is suspended, which
// is why we have a second pool.)
std::unique_ptr<WorkerPool> preemptionWorkers;

/**
Expand Down
0