bestEffortCommit the cache after writing the VERSION_KEY #8878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a slight performance optimization. When the cache is cold, we would write the VERSION_KEY but forget to commit the transaction. This meant that the first write to the cache when processing files would defensively abort any previous transaction, causing the VERSION_KEY to get written again. It's not clear that this should be user visible, and it's really not a big performance win, but it looks nicer in the logs because we see write, commit, write, commit, write, commit, instead of write, drop, write, commit, write, commit.
elliottt
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is just a slight performance optimization. When the cache is cold,
we would write the VERSION_KEY but forget to commit the transaction.
This meant that the first write to the cache when processing files would
defensively abort any previous transaction, causing the VERSION_KEY to
get written again.
It's not clear that this should be user visible, and it's really not a
big performance win, but it looks nicer in the logs because we see
write, commit, write, commit, write, commit, instead of write, drop,
write, commit, write, commit.
Test plan
Not possible to test except by looking in the trace-level logs.