8000 Update JSON.generate and JSON.fast_generate return types by dduugg · Pull Request #8909 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update JSON.generate and JSON.fast_generate return types #8909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update JSON.generate and JSON.fast_generate return types #8909

wants to merge 1 commit into from

Conversation

dduugg
Copy link
Contributor
@dduugg dduugg commented May 22, 2025

@dduugg dduugg requested a review from a team as a code owner May 22, 2025 15:14
@dduugg dduugg requested review from elliottt and removed request for a team May 22, 2025 15:14
@elliottt
Copy link
Collaborator

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_SMKQowPZAZHKUD
→ https://go/builds/bui_SMKR8IKeFUsOOc
→ https://go/builds/bui_SMKRocjJldh30O

@elliottt
Copy link
Collaborator

This looks good to me, but it raised a few errors on Stripe's codebase. I'll fix those, and then merge in this change. Thanks!

@elliottt
Copy link
Collaborator

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_SMhiLmdgd0Pouo
→ https://go/builds/bui_SMhj1qwIRt5sQc
→ https://go/builds/bui_SMhja1dco5tOjm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt Awaiting requested review from elliottt elliottt is a code owner automatically assigned from sorbet/core-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduugg @elliottt
0