RBS: Handle RBS annotations inside `case` .. `in` patterns #8901

Morriar · 2025-05-21T22:41:58Z

So this is properly understood:

case ARGV.first
in String
  ARGV.first #: as !nil
else
  ARGV #: as untyped
end

Also extracted consumeCommentsInsideNode to eliminate some repetition.

See included automated tests.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>

Morriar added 2 commits May 21, 2025 18:33

Handle RBS annotations in case .. in pattern matching

83a27eb

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>

Extract consumeCommentsInsideNode

c250033

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>

Morriar requested a review from a team as a code owner May 21, 2025 22:41

Morriar requested review from elliottt and removed request for a team May 21, 2025 22:41

Morriar self-assigned this May 21, 2025

elliottt approved these changes May 21, 2025

View reviewed changes

elliottt merged commit 6a63619 into sorbet:master May 21, 2025
14 checks passed

Morriar deleted the at-rbs-fix-case-pattern branch May 22, 2025 13:56

Provide feedback