Fix blank? return types #8914
Merged
Fix blank? return types #8914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think we should probably delete them. Is that okay with you? |
|
Works for me, done! |
jez
approved these changes
May 23, 2025
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_SMm0emRi1s4cIN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
blank?isn't actually defined in the stdlib for these (or any other classes):https://docs.ruby-lang.org/en/3.4/Date.html
https://docs.ruby-lang.org/en/3.4/DateTime.html
But, presumably these refer to the activesupport monkey-patches:
https://github.com/rails/rails/blob/c1d7d56e831acf0aff5f3e27a6b384f543f358d0/activesupport/lib/active_support/core_ext/date/blank.rb#L6-L13
https://github.com/rails/rails/blob/c1d7d56e831acf0aff5f3e27a6b384f543f358d0/activesupport/lib/active_support/core_ext/date_time/blank.rb#L6-L13
relates to #7494
(I'm also happy deleting these defs from the rbi, since they exist as annotations in rbi-central. IMO it would be better for them to live in a shim or a tapioca-generated rbi linked to their actual sources.)