Make flow-sensitivity understand instance_of? #3364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that, after calling `instance_of?` on an object, Sorbet knows about the type. Fixes #48
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build result here: |
DarkDimius
reviewed
Aug 15, 2020
| extend T::Sig | ||
|
|
||
| sig {params(x: T.any(A, B, C)).void} | ||
| def baz(x) |
There was a problem hiding this comment.
please add following test
# typed: true
x = "s"
if x.instance_of?(Object)
puts x
else
puts x
end
There was a problem hiding this comment.
Oh, this is interesting. We discussed offline and realized that the solution is harder to implement than just doing this.
Will comment on the original ticket
DarkDimius
requested changes
Aug 15, 2020
There was a problem hiding this comment.
https://github.com/sorbet/sorbet/pull/3364/files#r470918946
I expect it to fail in surprising way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that, after calling
instance_of?on an object, Sorbetknows about the type.
Motivation
Fixes #48
Test plan
Added automated tests.