8000 Remove AWSClient EventLoop APIs by adam-fowler · Pull Request #553 · soto-project/soto-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove AWSClient EventLoop APIs #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 19, 2023
Merged

Remove AWSClient EventLoop APIs #553

merged 11 commits into from
Jun 19, 2023

Conversation

adam-fowler
Copy link
Member
@adam-fowler adam-fowler commented Jun 18, 2023 •
edited
Loading
  • AWSClient.execute functions
  • AWSClient.getCredential
  • AWSClient.signURL/signHeaders
  • Fix up waiter, paginate, service and STSAssume code reliant on EventLoop based AWSClient.execute
  • Merge AWSClient, AWSService and AWSClient+Waiter files with async files

@adam-fowler adam-fowler requested a review from 0xTim June 18, 2023 17:40
@codecov
Copy link
codecov bot commented Jun 18, 2023 •
edited
Loading

Codecov Report

Merging #553 (bcf1612) into 7.x.x (d563f8b) will increase coverage by 1.12%.
The diff coverage is 93.85%.

❗ Current head bcf1612 differs from pull request most recent head 2410b49. Consider uploading reports for the commit 2410b49 to get more accurate results

@@            Coverage Diff             @@
##            7.x.x     #553      +/-   ##
==========================================
+ Coverage   76.37%   77.49%   +1.12%     
==========================================
  Files          79       76       -3     
  Lines        8190     7927     -263     
==========================================
- Hits         6255     6143     -112     
+ Misses       1935     1784     -151
Impacted Files Coverage Δ
Sources/SotoCore/Waiters/AWSClient+Waiter.swift 92.40% <90.00%> (-4.15%) ⬇️
Sources/SotoCore/Credential/STSAssumeRole.swift 92.06% <93.33%> (+0.68%) ⬆️
Sources/SotoCore/AWSClient.swift 92.51% <94.63%> (+32.41%) ⬆️
Sources/SotoCore/AWSClient+Paginate.swift 100.00% <100.00%> (ø)
Sources/SotoCore/AWSService.swift 94.44% <100.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

0xTim
0xTim requested changes Jun 18, 2023
View reviewed changes
Copy link
Member
@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a few left over event loops in the PR

@adam-fowler adam-fowler requested a review from 0xTim June 19, 2023 08:31
0xTim
0xTim reviewed 10000 Jun 19, 2023
View reviewed changes
Sources/SotoCore/Waiters/AWSClient+Waiter.swift Outdated
@@ -101,13 +101,11 @@ extension AWSClient {
/// - maxWaitTime: Maximum amount of time to wait
/// - logger: Logger used to provide output
/// - eventLoop: EventLoop to run API calls on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event loop is mentioned in the docs here but no longer used

0xTim
0xTim reviewed Jun 19, 2023
View reviewed changes
@adam-fowler @0xTim
Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift
2410b49 
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
@adam-fowler adam-fowler merged commit 88c019f into 7.x.x Jun 19, 2023
@adam-fowler adam-fowler deleted the remove-el-execute branch June 19, 2023 14:44
adam-fowler added a commit that referenced this pull request Jul 5, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
db85f36 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Jul 5, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
b9133be 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Jul 5, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
d2000b1 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Jul 5, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
4fa4084 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Jul 24, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
2de091b 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Jul 29, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
3180c25 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Aug 12, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
8bf8f85 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Dec 24, 2023
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
f76bceb 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
adam-fowler added a commit that referenced this pull request Apr 5, 2024
@adam-fowler @0xTim
Remove AWSClient EventLoop APIs (#553)
f6086dd 
* Remove AWSClient.execute calls with EventLoop

* Fix STSAssumeRole after removing EventLoop execute

* Fix AWSClient waiter code

* Remove commented out code

* Remove EL credential functions

* Merge async files with parent implementations

* Delete AWSClient+Waiter+async.swift

* Fix up paginate code

* Remove EventLoop from execute closure

* Changes requested in PR

* Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

---------

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @0xTim
0