8000 Hide request/response containers behind @_spi(SotoInternal) by adam-fowler · Pull Request #593 · soto-project/soto-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hide request/response containers behind @_spi(SotoInternal) #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

adam-fowler
Copy link
Member

Thoughts?

This hides public symbols in SotoCore that are required by Soto, but should not really be public to users of Soto

@adam-fowler adam-fowler requested a review from 0xTim October 21, 2023 15:07
@codecov
Copy link
codecov bot commented Oct 21, 2023

Codecov Report

Merging #593 (f019ef2) into 7.x.x (da842b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            7.x.x     #593   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files          77       77           
  Lines        6461     6461           
=======================================
  Hits         5196     5196           
  Misses       1265     1265           
Files Coverage Δ
Sources/SotoCore/Encoder/RequestContainer.swift 90.37% <ø> (ø)
Sources/SotoCore/Encoder/ResponseContainer.swift 75.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0