Add support for AWS_ROLE_ARN environment variables #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x.x #605 +/- ##
==========================================
+ Coverage 80.39% 80.51% +0.12%
==========================================
Files 78 78
Lines 6468 6575 +107
==========================================
+ Hits 5200 5294 +94
- Misses 1268 1281 +13 ☔ View full report in Codecov by Sentry. |
0xTim
approved these changes
Mar 30, 2024
a86be62 to
b79e41c
Compare
17face3 to
13f0cde
Compare
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
adam-fowler
added a commit
that referenced
this pull request
Apr 10, 2024
adam-fowler
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
AWS_ROLE_ARN,AWS_ROLE_SESSION_NAMEandAWS_WEB_IDENTITY_TOKEN_FILEenvironment variables.This ended up required more change than expected as it required another STS command merged into SotoCore. I have also tidied up a few things along the way.