Add support for sigV4a signing #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 80.49% 80.31% -0.19%
==========================================
Files 81 83
10000
+2
Lines 7019 7284 +265
==========================================
+ Hits 5650 5850 +200
- Misses 1369 1434 +65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
adam-fowler
reviewed
Mar 23, 2025
| var eq: UInt8 = 1 | ||
| let length = lhs.count | ||
|
|
||
| for i in 0..<length { |
There was a problem hiding this comment.
Can you a comment explaining what is happening here
adam-fowler
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hexDigest()much faster :)Fixes: #532