Add a test case for a single dimension evaluation #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way currently I am using assert False (so the current pytest is definitely not passing) to see the output. However, I do not know how to check if there is a reasoning part. Does anyone have an idea? |
|
@XuhuiZhou Could you help check this? I think this is basically a prompting issue? Maybe by changing the description of the goal dimension, it should work better? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 60.03% 62.01% +1.98%
==========================================
Files 47 55 +8
Lines 2402 2733 +331
==========================================
+ Hits 1442 1695 +253
- Misses 960 1038 +78
|
ProKil
requested changes
Jun 28, 2024
|
@bugsz Could you check if this fixes your problem? |
ProKil
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
I provide a test case for the issue mentions in #89.
Specifically this is done by adding a dummy evaluator with only one
goalevaluation dimension, and add a new option for theresponse_formatin evaluator.Besides, I use the same format as in real Sotopia simulation in testing, which makes the test case aligned with the actual evaluation.