Tags: soukazu97/rocksdb
Tags
Do not rely on ADL when invoking std::max_element (facebook#9608) Summary: Certain STLs use raw pointers and ADL does not work for them. Pull Request resolved: facebook#9608 Reviewed By: ajkr Differential Revision: D34583012 Pulled By: riversand963 fbshipit-source-id: 7de6bbc8a080c3e7243ce0d758fe83f1663168aa
Do not rely on ADL when invoking std::max_element (facebook#9608) Summary: Certain STLs use raw pointers and ADL does not work for them. Pull Request resolved: facebook#9608 Reviewed By: ajkr Differential Revision: D34583012 Pulled By: riversand963 fbshipit-source-id: 7de6bbc8a080c3e7243ce0d758fe83f1663168aa
Avoid popcnt on Windows when unavailable and in portable builds (face… …book#9680) Summary: Fixes facebook#9560. Only use popcnt intrinsic when HAVE_SSE42 is set. Also avoid setting it based on compiler test in portable builds because such test will pass on MSVC even without proper arch flags (ref: https://devblogs.microsoft.com/oldnewthing/20201026-00/?p=104397). Pull Request resolved: facebook#9680 Test Plan: verified the combinations of -DPORTABLE and -DFORCE_SSE42 produce expected compiler flags on Linux. Verified MSVC build using PORTABLE=1 (in CircleCI) does not set HAVE_SSE42. Reviewed By: pdillinger Differential Revision: D34739033 Pulled By: ajkr fbshipit-source-id: d10456f3392945fc3e59430a1777840f7b60b276
PreviousNext