refactor(chat): agentic context toolbox settings #8009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the toolbox settings and related logic for Deep Cody from `ToolboxManager` into `DeepCodyHandler`. This change consolidates the management of Deep Cody's features and settings within its handler, improving code organization and maintainability. The following changes were made: - Removed the `ToolboxManager` class and its singleton instance. - Moved the `getSettings`, `isAgenticChatEnabled`, and related observable logic into `DeepCodyHandler`. - Updated references to `toolboxManager` in `CodyToolFactory`, `CodyToolProvider`, `ChatController`, and `CodyToolProvider.test.ts` to use `DeepCodyHandler`. - Renamed `ToolboxManager.test.ts` to `DeepCodyHandler.test.ts` and updated its tests to reflect the changes. - Removed the A/B test comment in `DeepCody.ts` as it's no longer relevant. These changes improve the structure of the codebase and make it easier to manage Deep Cody's settings and features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the toolbox settings and related logic for Deep Cody from
ToolboxManagerintoDeepCodyHandler. This change consolidates the management of Deep Cody's features and settings within its handler, improving code organization and maintainability.The following changes were made:
ToolboxManagerclass and its singleton instance.getSettings,isAgenticChatEnabled, and related observable logic intotoolboxManagerinCodyToolFactory,CodyToolProvider,ChatController, andCodyToolProvider.test.tsto useDeepCodyHandler.ToolboxManager.test.tstoDeepCodyHandler.test.tsand updated its tests to reflect the changes.DeepCody.tsas it's no longer relevant.These changes improve the structure of the codebase and make it easier to manage Deep Cody's settings and features.
Test plan
Refactored without feature change. Everything should work the same as before. Green CI