Add "gateway benchmark-stream"(PRIME-651, PRIME-654, PRIME-655) #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdavid is this ready for review now? And is Code Search who you want reviewing it? |
|
@camdencheek, very sorry, I have no idea how I got Code Search tagged on this one. Pls ignore. |
|
Haha, no worries. I think we're auto-tagged on this repo since we're codeowners. |
emidoots
approved these changes
Dec 17, 2024
* Add --use-special-header to gateway benchmark * Add individual request CSV output to the "benchmark gateway" command
|
@slimsag, I've added some more changes to this but it's roughly the same as when you reviewed it, plus I went another quick round on it, adding a bit more docs and the such. I'll merge it to avoid growing it further, but feel free to re-review it and ask for fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
gateway benchmark-streamendpoint similar togateway benchmarkwith the capability to test the actual code completion endpoints on SG and CG instances.--use-special-headerflag and optional request-level CSV output to the "benchmark gateway" command.This is done for benchmarking purposes for these three issues:
See those issues for more context.
Test plan
Manual QA: I used the tool several times after the changes.