8000 refactor: Use Array#fetch instead of Array#[] to resolve type errors by tk0miya · Pull Request #1287 · soutaro/steep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Use Array#fetch instead of Array#[] to resolve type errors #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

refactor: Use Array#fetch instead of Array#[] to resolve type errors #1287

merged 1 commit into from
Nov 25, 2024

Conversation

tk0miya
Copy link
Contributor
@tk0miya tk0miya commented Oct 18, 2024 •
edited
Loading

47 -> 22

Note: This contains #1286

@tk0miya tk0miya force-pushed the refactor/Array.fetch branch from 06d4f24 to c9327a1 Compare October 18, 2024 13:31
soutaro
soutaro approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner
@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro added this to the Steep 1.9 milestone Nov 25, 2024
@tk0miya
Copy link
Contributor Author
tk0miya commented Nov 25, 2024

I merged the main branch to this PR to resolve conflicts and to make this easy to review.

@soutaro soutaro force-pushed the refactor/Array.fetch branch from ca35f21 to 7b5a677 Compare November 25, 2024 05:15
@soutaro
Copy link
Owner
soutaro commented Nov 25, 2024 •
edited
Loading

Oops... force push race...

@soutaro soutaro merged commit 0e24e0e into soutaro:master Nov 25, 2024
16 checks passed
@tk0miya tk0miya deleted the refactor/Array.fetch branch November 25, 2024 05:35
@tk0miya
Copy link
Contributor Author
tk0miya commented Nov 25, 2024

😓 Don't mind. Thank you for reviewing and merging!

@soutaro soutaro added the Released The PR is already included in a published release label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @soutaro
0