Support for certificates with expiration date #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #471 +/- ##
=========================================
+ Coverage 80.2% 80.6% +0.4%
=========================================
Files 26 27 +1
Lines 1697 1743 +46
=========================================
+ Hits 1362 1406 +44
- Misses 215 216 +1
- Partials 120 121 +1 ☔ View full report in Codecov by Sentry. |
7ba2761 to
9abc783
Compare
fasmat
approved these changes
Apr 17, 2024
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for certificates with an optional expiration date. A certificate is now a scale-encoded combination of the node's ID and (optional) expiration time. If the expiration time is
nil, the certificate does not expire.The function to verify a certificate is exported in
sharedpkg for the node to verify the certs it gets from a certifier.