don't return certifier info if it is not configured #543
+52
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #543 +/- ##
=======================================
Coverage 78.2% 78.3%
=======================================
Files 27 27
Lines 2264 2265 +1
=======================================
+ Hits 1772 1775 +3
+ Misses 361 358 -3
- Partials 131 132 +1 ☔ View full report in Codecov by Sentry. |
695ad7e to
ffd9b3e
Compare
fasmat
approved these changes
Nov 14, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #514. The /info wrongly responds with an empty certifier config instead of a null.
Getting:
{ "certifier": { "url": "", "pubkey": "" } }Expected:
{ "certifier": null }The problem stems from the fact that the
go-flagsinitializes theCertiferpointer field ofregistration.Configregardless of whether any of the fields is set with a flag. Before the regression, thecfg.Certifierwas manually set tonilif the certifier URL wasn't set. It's not cleared anymore because of the support for trusted keys (added in #514).