8000 JP-1448: Only load science/bkg members in calimage3 by hbushouse · Pull Request #4937 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1448: Only load science/bkg members in calimage3 #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2020
Merged

JP-1448: Only load science/bkg members in calimage3 #4937

merged 2 commits into from
May 12, 2020

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented May 12, 2020 •
edited
Loading

Updated the calwebb_image3 pipeline module to only load science and background member types from the input ASN (just like calwebb_spec3). Verified that this still works properly when the input is a single cal file and not an ASN.

Fixes #4933 / JP-1448

@hbushouse hbushouse added this to the Build 7.5 milestone May 12, 2020
@codecov
Copy link
codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #4937 into master will decrease coverage by 0.02%.
The diff coverage is 6.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4937      +/-   ##
==========================================
- Coverage   52.43%   52.40%   -0.03%     
==========================================
  Files         402      402              
  Lines       35613    35631      +18     
  Branches     5523     5526       +3     
==========================================
+ Hits        18672    18674       +2     
- Misses      15809    15825      +16     
  Partials     1132     1132
Flag Coverage Δ
#unit 52.40% <6.45%> (-0.03%) ⬇️
Impacted Files Coverage Δ
jwst/pipeline/calwebb_image3.py 26.78% <0.00%> (-0.49%) ⬇️
jwst/source_catalog/source_catalog.py 27.41% <4.76%> (-0.37%) ⬇️
jwst/source_catalog/source_catalog_step.py 23.07% <12.50%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8534aed...a47a471. Read the comment docs.

@hbushouse hbushouse merged commit 88de45c into spacetelescope:master May 12, 2020
@hbushouse hbushouse deleted the jp1448 branch May 12, 2020 20:54
@stscijgbot-jp stscijgbot-jp mentioned this pull request May 12, 2020
Closed
stscieisenhamer pushed a commit to stscieisenhamer/jwst that referenced this pull request Jun 5, 2020
@hbushouse @stscieisenhamer
JP-1448: Only load science/bkg members in calimage3 (spacetelescope#4937
8f3cdce 
)
@hbushouse hbushouse mentioned this pull request Jun 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@jdavies-st jdavies-st Awaiting requested review from jdavies-st

Assignees
No one assigned
Labels
image3 pipeline
Projects
None yet
Milestone
Build 7.5
Development

Successfully merging this pull request may close these issues.

calwebb_image3 pipeline is loading all ASN members instead of just science
2 participants
@hbushouse @stscieisenhamer
0