Update abmag error calculation #4945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4945 +/- ##
=======================================
Coverage 52.41% 52.41%
=======================================
Files 402 402
Lines 35638 35638
Branches 5527 5527
=======================================
Hits 18681 18681
Misses 15825 15825
Partials 1132 1132
Continue to review full report at Codecov.
|
hbushouse
approved these changes
May 14, 2020
stscieisenhamer
pushed a commit
to stscieisenhamer/jwst
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to abmag error calculation to be valid for all S/N. Note that all errors in the source catalog are still reported as NaN (because we don't have errors for the drizzled images yet), so I don't think this needs a changelog entry.