8000 JP-1454: Exit gracefully if APCORR data is missing by larrybradley · Pull Request #4948 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1454: Exit gracefully if APCORR data is missing #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2020
Merged

JP-1454: Exit gracefully if APCORR data is missing #4948

merged 2 commits into from
May 14, 2020

Conversation

larrybradley
Copy link
Member
@larrybradley larrybradley commented May 14, 2020 •
edited by hbushouse
Loading

JP-1454 is caused by an invalid "BRIGHT" subarray in the MIRI APCORR reference file. It should be called "BRIGHTSKY".

This PR raises an error if APCORR reference file data is missing. It also now catches RuntimeError to print a warning message and exit gracefully for reference file errors.

Fixes #4947 / JP-1454

@larrybradley larrybradley added this to the Build 7.5 milestone May 14, 2020
jwhite3
jwhite3 approved these changes May 14, 2020
View reviewed changes
Copy link
@jwhite3 jwhite3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Much more helpful error message in this case

@codecov
Copy link
codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #4948 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4948      +/-   ##
==========================================
- Coverage   52.47%   52.45%   -0.02%     
==========================================
  Files         403      403              
  Lines       35722    35732      +10     
  Branches     5542     5543       +1     
==========================================
  Hits        18745    18745              
- Misses      15839    15849      +10     
  Partials     1138     1138
Flag Coverage Δ
#unit 52.45% <0.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
jwst/source_catalog/source_catalog.py 27.27% <0.00%> (-0.15%) ⬇️
jwst/source_catalog/source_catalog_step.py 20.33% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ea2ec...91c4fb4. Read the comment docs.

@hbushouse hbushouse merged commit ef35d57 into spacetelescope:master May 14, 2020
@larrybradley larrybradley deleted the empty-apcorr branch May 14, 2020 16:03
@stscijgbot-jp stscijgbot-jp mentioned this pull request May 14, 2020
Closed
stscieisenhamer pushed a commit to stscieisenhamer/jwst that referenced this pull request Jun 5, 2020
@larrybradley @stscieisenhamer
JP-1454: Exit gracefully if APCORR data is missing (spacetelescope#4948)
aab89a0 
* Raise error if APCORR reference file data is missing

* Catch RuntimeError and exit gracefully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Revie 6AF5 wers

@hbushouse hbushouse hbushouse approved these changes

@jwhite3 jwhite3 jwhite3 approved these changes

@jdavies-st jdavies-st Awaiting requested review from jdavies-st

Assignees
No one assigned
Labels
source catalog
Projects
None yet
Milestone
Build 7.5
Development

Successfully merging this pull request may close these issues.

source_catalog crashing on MIRI image
3 participants
@larrybradley @hbushouse @jwhite3
0