JP-1294 Update coron3 for new outlier detection application #4968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level 2c outputs are gone due to needing intent to be redefined for these. DQ is not propagated nor used during stack, klip, and subtraction.
Codecov Report
@@ Coverage Diff @@
## master #4968 +/- ##
==========================================
+ Coverage 52.48% 52.52% +0.04%
==========================================
Files 403 403
Lines 35729 35739 +10
Branches 5544 5546 +2
==========================================
+ Hits 18751 18771 +20
+ Misses 15841 15830 -11
- Partials 1137 1138 +1
Continue to review full report at Codecov.
|
hbushouse
reviewed
May 20, 2020
jdavies-st
reviewed
May 22, 2020
jdavies-st
approved these changes
May 23, 2020
hbushouse
reviewed
May 27, 2020
| 2) Accumulate all reference PSF images into a single product | ||
| 3) Align every PSF image to every science target image | ||
| 4) Compute an optimal PSF fit and subtract it from every science target image | ||
| 5) Compare the PSF-subtracted target images against one another to identify outliers |
There was a problem hiding this comment.
This line needs to be removed - it's replaced by item 1 (we still have a total of 5 steps, not 6).
stscieisenhamer
added a commit
to stscieisenhamer/jwst
that referenced
this pull request
Jun 5, 2020
…escope#4968) Changes: * Fix spelling in code comments * Run outlier detection on each psf. * Apply outlier to each target Level 2c outputs are gone due to needing intent to be redefined for these. DQ is not propagated nor used during stack, klip, and subtraction. * Updated logging for new step order * Update saving of CRFINTS results * Update comment wording * Remove unnecessary commented-code * Add to_container method to CubeModel * Refactor data conversion from CubeModel to ModelContainer * Add tests for getarray_noinit * Restore a deleted comment about skipped resampling * Update changelog * Fixing single to double back-tick issue. uhhhhhg. * Remove unused code in test * Fix random PEP8 issues in tests * Update coron3 regtest * Update coron3 pipeline documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-1294 / #4556