8000 JP-1490: skip assign_mtwcs if target coords missing by hbushouse · Pull Request #5015 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1490: skip assign_mtwcs if target coords missing #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2020
Merged

JP-1490: skip assign_mtwcs if target coords missing #5015

merged 3 commits into from
Jun 3, 2020

Conversation

hbushouse
Copy link
Collaborator

If any of the input images to the assign_mtwcs step are missing the MT_RA or MT_DEC keyword values, issue a warning and skip the step.

Fixes #5014 / JP-1490

@hbushouse hbushouse added this to the Build 7.6 milestone Jun 3, 2020
@hbushouse hbushouse requested review from nden and stscieisenhamer June 3, 2020 13:42
@codecov
Copy link
codecov bot commented Jun 3, 2020 •
edited
Loading

Codecov Report

Merging #5015 into master will decrease coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5015      +/-   ##
==========================================
- Coverage   53.16%   53.16%   -0.01%     
==========================================
  Files         400      400              
  Lines       35220    35230      +10     
  Branches     5467     5469       +2     
==========================================
+ Hits        18725    18729       +4     
- Misses      15361    15367       +6     
  Partials     1134     1134
Flag Coverage Δ
#unit 53.16% <38.46%> (-0.01%) ⬇️
Impacted Files Coverage Δ
jwst/assign_mtwcs/moving_target_wcs.py 24.44% <33.33%> (+4.44%) ⬆️
jwst/assign_mtwcs/assign_mtwcs_step.py 55.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270a8eb...c1f332b. Read the comment docs.

nden
nden approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator
@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse hbushouse merged commit 72b81ef into spacetelescope:master Jun 3, 2020
@hbushouse hbushouse deleted the mtwcs branch June 3, 2020 18:41
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

Assignees
No one assigned
Labels
assign_mtwcs
Projects
None yet
Milestone
Build 7.6
Development

Successfully merging this pull request may close these issues.

assign_mtwcs fails when MT_RA/DEC keywords are missing
2 participants
@hbushouse @nden
0