10000 JP-1481 Update was_source_model after reading new data by ddavis-stsci · Pull Request #5076 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1481 Update was_source_model after reading new data #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2020
Merged

JP-1481 Update was_source_model after reading new data #5076

merged 3 commits into from
Jun 18, 2020

Conversation

ddavis-stsci
Copy link
Collaborator
@ddavis-stsci ddavis-stsci commented Jun 18, 2020 •
edited by hbushouse
Loading

This issue here was that after the data are ordered by source the "was_source_model" is not updated. This rechecks the input model container in run_extract1d so that the correct path through the module is selected.

Fixes #5004 / JP-1481

@ddavis-stsci ddavis-stsci marked this pull request as ready for review June 18, 2020 12:53
@hbushouse hbushouse added this to the Build 7.6 milestone Jun 18, 2020
hbushouse
hbushouse reviewed Jun 18, 2020
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to tell what effect this may have in the broader context of processing various different types of inputs, but I guess the regression tests will give us that answer.

Just needs a change log entry before merging.

@codecov
Copy link
codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #5076 into master will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5076      +/-   ##
==========================================
- Coverage   53.04%   53.04%   -0.01%     
==========================================
  Files         401      401              
  Lines       35597    35601       +4     
  Branches     5518     5519       +1     
==========================================
+ Hits        18883    18884       +1     
- Misses      15576    15578       +2     
- Partials     1138     1139       +1
Flag Coverage Δ
#unit 53.04% <25.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
jwst/extract_1d/extract.py 8.53% <25.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467fa7e...d32667f. Read the comment docs.

@ddavis-stsci
Copy link
Collaborator Author

It does work best if you add the files you've changed...

@ddavis-stsci ddavis-stsci merged commit d91fff4 into spacetelescope:master Jun 18, 2020
@ddavis-stsci ddavis-stsci deleted the JP-1481 branch June 18, 2020 13:51
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@jwhite3 jwhite3 Awaiting requested review from jwhite3

Assignees
No one assigned
Labels
extract_1d
Projects
None yet
Milestone
Build 7.6
Development

Successfully merging this pull request may close these issues.

Error in calwebb_spec3 extract_1d step for NIRISS WFSS data
2 participants
@ddavis-stsci @hbushouse
0