8000 extract_1d style; readability updates by jwhite3 · Pull Request #5079 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

extract_1d style; readability updates #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 17, 2020
Merged

extract_1d style; readability updates #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5bdd36
Style; readability updates
Jun 18, 2020
cbea2d4
restrict function/method/class defs to 80 characters
Jun 25, 2020
025e3d3
Bug fixes
Jun 30, 2020
693c158
Merge branch 'master' into extract1d-readability
hbushouse Jul 16, 2020
84a495d
Fix syntax issues
hbushouse Jul 16, 2020
927fc7d
More syntax and import fixes
hbushouse Jul 16, 2020
cb86435
Updates from review comments
hbushouse Jul 16, 2020
9a9a2be
Fix bugs
hbushouse Jul 17, 2020
f5bc3ac
Update JenkinsfileRT to use pytest-sugar for regtests
hbushouse Jul 17, 2020
1008608
Update change log for this PR and several missing source_catalog PRs …
hbushouse Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ datamodels
extract_1d
----------

- Rechecks the input model container in run_extract1d to select the correct processing. [#5076]
- Implement aperture corrections in the Extract1dStep. [#4902]

- Implement aperture correction in the Extract1dStep. [#4902]
- Recheck the input model container in run_extract1d to select the correct processing. [#5076]

- Rework/refactor many functions for style and readability. [#5079]

extract_2d
----------
Expand Down Expand Up @@ -246,12 +248,18 @@ rscd
source_catalog
--------------

- Add more concentration indices and update step docs. [#4906, #4908]

- Added fallback background estimation method to make background
estimation moare robust. [#4929]

- Fixed the nearest-neighbor code to handle the case of exactly one
detected source. [#4929]

- Update abmag error calculation. [#4945]

- Exit gracefully if APCORR ref file is missing. [#4948]

tweakreg
--------

Expand Down Expand Up @@ -426,6 +434,10 @@ source_catalog

- Updated step arguments in the documentation. [#4723]

- Updated to include aperture photometry and aperture corrections. [#4819]

- Rename 10000 AB-to-Vega reference file type to ABVEGAOFFSET. [#4872]

srctype
-------

Expand Down
2 changes: 1 addition & 1 deletion JenkinsfileRT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ bc0.conda_packages = [
bc0.pip_reqs_files = ['requirements-sdp.txt']
bc0.build_cmds = [
"pip install -e .[test,ephem]",
"pip install pytest-xdist",
"pip install pytest-xdist pytest-sugar",
'echo "CRDS_CONTEXT = $(crds list --contexts $CRDS_CONTEXT --mappings | grep pmap)"',
]
bc0.test_cmds = [
Expand Down
15 changes: 10 additions & 5 deletions jwst/cube_build/ifu_cube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,15 +1098,20 @@ def determine_cube_parameters(self):


log.debug('spatial size %d', self.spatial_size)
log.debug('spectral size %d', self.spectral_size)
if self.spectral_size is not None:
log.debug('spectral size %d', self.spectral_size)
log.debug('spatial roi %d', self.rois)
log.debug('wave min and max %d %d', self.wavemin, self.wavemax)
log.debug('linear wavelength %d', self.linear_wavelength)
log.debug('roiw %d ', self.roiw)
if self.roiw is not None:
log.debug('roiw %d ', self.roiw)
log.debug('output_type %s ',self.output_type)
log.debug('weight_power %d ',self.weight_power)
log.debug('softrad %d ',self.soft_rad)
log.debug('scalerad %d ',self.scalerad)
if self.weight_power is not None:
log.debug('weight_power %d ',self.weight_power)
if self.soft_rad is not None:
log.debug('softrad %d ',self.soft_rad)
if self.scalerad is not None:
log.debug('scalerad %d ',self.scalerad)

# ******************************************************************************

Expand Down
Loading
0